Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(surveys): favor "properties" to "user properties", given that we can target by user and group properties #26991

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

dmarticus
Copy link
Contributor

Problem

The info is in the title; I noticed that we were saying "user properties" for all of our targeting but we can technically target groups too, so this is more correct IMO.

Copy link
Contributor

@Phanatic Phanatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

Copy link
Contributor

@havenbarnes havenbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@dmarticus dmarticus enabled auto-merge (squash) December 17, 2024 20:27
Copy link
Contributor

Size Change: 0 B

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.11 MB

compressed-size-action

@dmarticus dmarticus merged commit 54e483b into master Dec 17, 2024
99 of 100 checks passed
@dmarticus dmarticus deleted the fix/better-copy-for-targeting branch December 17, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants